Check after each effect if the unit is still alive before performing actions #250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used
some
to check if after any effect the unit.isAlive() would return false.In case the unit is not alive after any effect, it will skip the next iterations and return true to
diedAfterEffects
.Then, I added another check (
!diedAfterEffects
) before starting to perform the unit actions.Let me know if you think this can be improved in any way.