added action tag #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,10 +69,10 @@ func (w *Writer) Start() { | |||
| continue // no server tag :( | |||
| } | |||
|
|
|||
| tags := m.Tags.Filter(&[]string{"status", "user", "type", "region"}) | |||
| tags := m.Tags.Filter(&[]string{"status", "user", "action", "type", "region"}) | |||
There was a problem hiding this comment.
Maybe "category" or "controller" is more suitable? After all we usually have "action" in "script".
There was a problem hiding this comment.
the idea was "use script if that's enough for you, or put class name into script, and action into, well, action".
so there's two options:
- script=Some_Class_Name, action=list
- category=Some_Class_Name, script=Some_Class_Name::list
There was a problem hiding this comment.
Second option allows more general approach, and that's the way i'd like it to be. In category you can set more generic part of application.
script=Some_Class::_action category=Search
script=Some_Other_Class::_otherAction category=Item
Script and action are more limiting. And with first option we may lose backward compatibility.
|
changed action to category |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.