Optimize CSS & Sync with Vanilla Foundation #987
Conversation
Removed unnecessary styling that deviates from vanilla Foundation. Added new classes to use as selectors in place of Foundation component classes. This prevents additional Foundation components like the Top Bar from being affected by the unique navigation styling. Updated HMTL for Title Bar and Top Bar components to match the Docs for the title.
Where appropriate, ID selectors have been replaced with classes to reduce specificity. A big offender were the individual templates, which used IDs to determine column layouts. Now they all share the same class '.main-wrap' for the basic column styling and make use of helper classes for variations like .
Also update '404.php' markup to use the new class based content layout.
|
Travis is failing because the WP Coding Standards aren't loading. Try rerunning Travis to see if the issue has been resolved.
|
|
@EricRihlmann : Unfortunately there has been quite a few cases where WP Coding Standards have not worked as expected. Not sure what |
WordPress Coding Standards is not compatible with latest version of PHPCS v 3.0. See WordPress/WordPress-Coding-Standards#947
|
@olefredrik Ultimately the problem was that the WordPress Coding Standards are not compatible yet with version FYI, for the other open pull requests, you should be able to rerun the builds (I can't see the button because I don't have access to the repo). You can also just close and reopen a PR to force the build to restart. |
|
Good stuff, @EricRihlmann ! Thanks for all the time and effort you have put into this! 👍 |
|
Thank you @EricRihlmann for fixing Travis and cleaning up inconsistencies in the code. Just a thought: now that Travis is running and FoundationPress code is more standard compliant, wouldn't it be a good time to revisit the discussion of the exclusions from WPCS? |
Take a look at the extended commit messages for further details.