This repository has been archived by the owner on Sep 16, 2019. It is now read-only.
Change off-canvas menu height to affect all menus #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the line ul#menu-main-menu only targets the specific menu named 'main-menu'. Shouldn't it target ALL menus placed in offcanvas?
|
I'm not sure this is a good idea. Are you suggesting that nested submenus inside an off-canvas menu should have a 100vh height attribute? Can you explain why this makes sense? |
|
I'm sorry. I did not mean all menus inside including submenus. I meant only the first menu, but not called by name Maybe some background info: I noticed the off-canvas menu is not 100% height and so the background is not complete filled with the color from settings. I tracked it down to this line, just setting |
olefredrik
added a commit
that referenced
this pull request
Mar 7, 2016
Change off-canvas menu height to affect all menus
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the line
ul#menu-main-menuonly targets the specific WordPress menu namedmain-menu. Shouldn't it target ALL menus placed in offcanvas?