Feature/improve mobile navigation customizer #413
Conversation
|
@AdamChlan : I've spent some of the evening in an attempt to improve the mobile navigation settings further. In short, I have made it possible to control the position (left or right) both for the topbar and offcanvas setting, directly from the theme customizer. I have also cleared away the global variables and used filters instead. The header.php file is cleaned up and part of the code has been moved to the template file for the offcanvas menu. As this is a medium-sized rewrite, I'd love to get your view on it before I merge the pull request. Do you see anything I should have done differently? Anybody else that wants to do a quick code review on this? |
|
@olefredrik These look like good updates to me. Definitely like the idea of making header.php more streamlined. Looking at the Zurb docs, I think this provides a nice base of options for mobile menus. The only other thing I saw which we could consider is the ability to have both a right and left off-canvas, but I'm not sure how popular that functionality is. It's always something that could be added down the road as well. |
|
@AdamChlan : Good stuff. Thanks! I'll have another look through it tonight just to make sure I haven't missed anything. |
…onCustomizer Feature/improve mobile navigation customizer
No description provided.