This repository has been archived by the owner on Sep 16, 2019. It is now read-only.
Refine Webpack watch + build functions #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1202 and #1204.
I have no idea how I didn't see this before, but if you
console.log(webpackConfig)in the current webpack.watch function, it returns undefined -- meaning no config passed in to the watcher, and no transforms on any .js files, hence the errors referenced above.This PR moves the config into the scope of the
webpackobject, and adds a bit of sugar/cleanup otherwise. Also -- the 'exclude' option is now set so that the Foundation .js files are always transpiled down to ES5 (as opposed to just in production), as I noticed syntax errors pop up while testing in IE10 and 11 during --dev.