Templating changes... #1098
Templating changes... #1098
Conversation
template-parts/content.php
Outdated
| <header> | ||
| <h2><a href="<?php the_permalink(); ?>"><?php the_title(); ?></a></h2> | ||
| <h1 class="entry-title"><?php the_title(); ?></h1> |
There was a problem hiding this comment.
This is going to result in multiple h1 elements on archive pages, which we don't want. There needs to be conditionals throughout this file that use is_single() to dictate different content depending on if it's a single post or an archive page.
See here for an example:
https://github.com/WordPress/twentyseventeen/blob/master/components/post/content.php
archive.php
Outdated
| @@ -18,7 +18,7 @@ | |||
| get_header(); ?> | |||
|
|
|||
| <div class="main-wrap" role="main"> | |||
There was a problem hiding this comment.
role="main" can be dropped from here. It belongs on the main element but we don't need it there since it's applied by default.
|
Hi @JPOak ! Thanks a lot for this. Haven't had time to review yet, been busy the last few days. Will review your changes tomorrow. By the way, have you registered for Hacktoberfest yet? If not, you should. Make 4 pull requests (in any repo on Github) by the end of the month, and you'll receive a cool Hacktoberfest t-shirt. |
|
Tested ok 👍 |
#1094 #1091 #1057
@olefredrik @colin-marshall I realized when I went through the above issues that you needed to do them all at once. Also, they affected a lot of little things across many files. Hopefully, this PR will be helpful to get the ball rolling on changing some of the templating discussed (with some review and discussion.)