Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Add fontawesome handle #1030

Merged
merged 1 commit into from
Aug 8, 2017
Merged

Add fontawesome handle #1030

merged 1 commit into from
Aug 8, 2017

Conversation

olefredrik
Copy link
Owner

No description provided.

@olefredrik olefredrik merged commit ffc459b into master Aug 8, 2017
@olefredrik olefredrik deleted the fontawesome-handle branch August 8, 2017 07:24
@linuxbastard
Copy link
Contributor

Minor wording issue:
Enqueue FontAwesome from CDN. Uncomment the line below if you don't need FontAwesome.

It should either be:

// Enqueue FontAwesome from CDN. Uncomment the line below if you need FontAwesome.
//wp_enqueue_script( 'fontawesome', 'https://use.fontawesome.com/5016a31c8c.js', array(), '4.7.0', true );

OR

// Enqueue FontAwesome from CDN. Comment out the line below if you don't need FontAwesome.
wp_enqueue_script( 'fontawesome', 'https://use.fontawesome.com/5016a31c8c.js', array(), '4.7.0', true );

I of course prefer not to load anything until we need it, so the first one works for me.

@olefredrik
Copy link
Owner Author

@linuxbastard : I agree. If you care to make a pull request for the first one, I'll merge it into master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants