Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to disable camera when the component is destroyed in vue3 #26

Merged
merged 15 commits into from
Jan 22, 2022

Conversation

disha1202
Copy link
Contributor

Updated the life cycle hook from beforeDestroy to beforeUnmount as it is deprecated in vue3.

Copy link
Owner

@olefirenko olefirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@disha1202 Thank you for PR!

@olefirenko olefirenko merged commit abd16c7 into olefirenko:master Jan 22, 2022
@olefirenko
Copy link
Owner

olefirenko commented Jan 22, 2022

The link to official docs for reference https://v3.vuejs.org/guide/migration/vnode-lifecycle-events.html#migration-strategy

The lifecycle hooks beforeDestroy and destroyed have been renamed to beforeUnmount and unmounted respectively, so the corresponding event names will also need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants