Table wrapper for markdown tables #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea, I've changed the "overflow-x: scroll" to use "auto" instead so that it only appears when actually oveflowing. |
oleeskild
added a commit
that referenced
this pull request
Apr 18, 2023
* Move vercel.json to filesToAdd (#115) * vercel.json to filesToAdd * Netlify config doesn't need to be overwritten on every update --------- Co-authored-by: Ole Eskild Steensen <oleeskild@users.noreply.github.com> * Table wrapper for markdown tables (#114) * table wrapper for markdown tables * minimal formatting * minimal formatting * Only show scroll when neccessary --------- Co-authored-by: Ole Eskild Steensen <oleeskild@users.noreply.github.com> * Image optimization (#116) * image optimizations * added cache to gitignore * fault tolerant img generation * crash fix --------- Co-authored-by: Ole Eskild Steensen <oleeskild@users.noreply.github.com> * Bump @azure/storage-blob from 12.13.0 to 12.14.0 Bumps [@azure/storage-blob](https://github.com/Azure/azure-sdk-for-js) from 12.13.0 to 12.14.0. - [Release notes](https://github.com/Azure/azure-sdk-for-js/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-js/blob/main/documentation/Changelog-for-next-generation.md) - [Commits](https://github.com/Azure/azure-sdk-for-js/compare/@azure/storage-blob_12.13.0...@azure/storage-blob_12.14.0) --- updated-dependencies: - dependency-name: "@azure/storage-blob" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Utsob Roy <roy@utsob.me> Co-authored-by: Ole Eskild Steensen <oleeskild@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some themes (at least in the Minimal theme and/or in all themes), markdown tables are not scrollable horizontally in mobiles.
That can be fixed by an
overflow-y: autoon thecm-s-obsidianclass but that breaks the styling. I've googled it a bit and found that in such situations tables should be wrapped in another container, and that container should haveoverflow-y: auto.It is true that our current setup allows us to implement this without touching the core template, but I thought it was a problem most will face now or then and we can ship the solution with the template.