Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): add Traditional Chinese translation #230

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

junyussh
Copy link
Contributor

@junyussh junyussh commented Mar 4, 2020

Add Taiwanese Traditional Chinese translation

@olOwOlo
Copy link
Owner

olOwOlo commented Apr 13, 2020

Thank you for your translation, but it looks like this is more than just a PR about translation?

@junyussh
Copy link
Contributor Author

When I using your theme, I found it doesn't insert Google Analytics verification code snippets and fix the problem.
If you don't want to merge the part of code, I can re-open the PR of the translation.

@olOwOlo
Copy link
Owner

olOwOlo commented Apr 15, 2020

When I using your theme, I found it doesn't insert Google Analytics verification code snippets and fix the problem.

Make sure you are not in hugo server mode.

If you don't want to merge the part of code, I can re-open the PR of the translation.

Just modify it directly on the current branch, no need to re-open PR.

@junyussh
Copy link
Contributor Author

Make sure you are not in hugo server mode.

I found this problem after deploying.

@olOwOlo
Copy link
Owner

olOwOlo commented Apr 18, 2020

Make sure you are not in hugo server mode.

I found this problem after deploying.

Cannot reproduce.

@panda-z
Copy link
Contributor

panda-z commented May 13, 2020

@junyussh

The GA issue has been fixed by #260 .

Can you rebase the branch to drop the GA commit and only include the translation?

@junyussh
Copy link
Contributor Author

OK, I have reverted my branch. You can merge it now.

@olOwOlo olOwOlo merged commit 4be1234 into olOwOlo:master Sep 10, 2020
@olOwOlo
Copy link
Owner

olOwOlo commented Sep 10, 2020

Thank you ~

daymade pushed a commit to daymade/hugo-theme-even that referenced this pull request Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants