Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add external_namespace property for app_user_schema and user_schema #102

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Add external_namespace property for app_user_schema and user_schema #102

merged 1 commit into from
Aug 31, 2020

Conversation

mantoine96
Copy link
Contributor

@mantoine96 mantoine96 commented Apr 3, 2020 •
edited
Loading

Add external_namespace property for app_user_schema and user_schema

Fixes #96

@mantoine96
Copy link
Contributor Author

mantoine96 commented Jul 22, 2020 •
edited
Loading

@noinarisak Could you take a look at this PR? The label is unfortunately not correct and this should also be tagged as an enhancement / bugfix.

Thanks!

@noinarisak noinarisak added needs-investigation Needs further investigation bug enhancement Asking for new behavior or feature and removed needs-investigation Needs further investigation labels Aug 31, 2020
@noinarisak noinarisak self-assigned this Aug 31, 2020
@noinarisak noinarisak merged commit 6b73015 into okta:master Aug 31, 2020
@noinarisak
Copy link
Contributor

Hey @thehunt33r ! Sorry for being MIA, it been just a crazy couple months.

@mantoine96
Copy link
Contributor Author

Thank you @noinarisak! I think we can all agree these last few months have been crazy!

@mantoine96 mantoine96 deleted the External-Namespace branch September 1, 2020 05:59
ymylei added a commit to ymylei/terraform-provider-okta that referenced this pull request Sep 20, 2020
@ymylei @mbudnek
@ChristophShyper @thekbb @noinarisak @tracypholmes @jpf @mantoine96 @snolan-amount
Merging upstream (#1)
e75ffc2 
* Add resource definiton for Okta Event Hooks (#14)

* Add resource definiton for Okta Event Hooks

This adds a new okta_event_hook resource for managing Event Hooks.  The
resource itself is mostly a copy/paste job from the existing
okta_inline_hook resource.  Since the two are so similar I re-worked
sdk/inline_hooks.go to generalize it to work with both event hooks and
inline hooks and renamed it to sdk/hooks.go.

* Revert CHANGELOG.md

The changelog entries get created by maintainers as part of the
release process.

* Get rid of overly-clever JSON formatting

* Split hooks.go back apart into inline_hooks.go and event_hooks.go

* Clean up and add comments to help explain testCheckResourceSetAttr

* Adding support for GROUP_MEMBERSHIP_ADMIN & REPORT_ADMIN (okta#138)

* adding documentation on the support of the group membership admin role

* added group membership role to list of allowed options

* updating tests to account for new group role

* added REPORT_ADMIN to API validated roles and test

* Removing comment on activating since this is now GA

* Fixed provider_id typo in okta_factor in web documentation (okta#126)

* Fixed provider_id typo in okta_factor

Taken from https://github.com/articulate/terraform-provider-okta/blob/master/okta/resource_okta_factor.go

* Added allowed provider_id values for factor resource web page

Based on https://github.com/articulate/oktasdk-go/blob/master/okta/org.go

* Fix terraform import command for okta_mfa_policy (okta#127)

To import okta_mfa_policy the policy ID is required,
an app id will not work.

* Update app_oauth.html.markdown (okta#151)

* Update app_oauth.html.markdown

Update. Documentation on `"private_key_jwt:` in `resource_app_oauth` was missing.

* Add example hcl for private_key_jwt

Co-authored-by: noi narisak <noi.narisak@users.noreply.github.com>

* Update CHANGELOG.md

* Fix due the Hashicorp expecting particular CHANGLOG format

* v3.4.0

* Cleanup after v3.4.0 release

* Update .goreleaser.yml

* Update CHANGELOG.md (okta#169)

Co-authored-by: noi narisak <noi.narisak@users.noreply.github.com>

* Add external_namespace property for app_user_schema and user_schema (okta#102)

LGTM!

* Add password import inline hook type (okta#168)

Co-authored-by: noi narisak <noi.narisak@users.noreply.github.com>

* Fix inline hook example code to match version that is supported (okta#175)

Co-authored-by: noi narisak <noi.narisak@users.noreply.github.com>

* Update app_group_assignment.html.markdown (okta#165)

Corrected the help for importing, as per the help in the CLI, you need the app_id and group_id not the assignment id.

* Update CHANGELOG (okta#177)

Co-authored-by: noi narisak <noi.narisak@users.noreply.github.com>

* Update .goreleaser.yml (okta#178)

Co-authored-by: noi narisak <noi.narisak@users.noreply.github.com>

Co-authored-by: Miles Budnek <mbudnek@mbudnek.com>
Co-authored-by: Krzysztof Szyper <45788587+ChristophShyper@users.noreply.github.com>
Co-authored-by: Kevin Behrens <kevin@thekbb.net>
Co-authored-by: Noi Narisak <341437+noinarisak@users.noreply.github.com>
Co-authored-by: noi narisak <noi.narisak@users.noreply.github.com>
Co-authored-by: Tracy P Holmes <12778804+tracypholmes@users.noreply.github.com>
Co-authored-by: tf-release-bot <terraform@hashicorp.com>
Co-authored-by: Joel Franusic <joel@franusic.com>
Co-authored-by: Matthieu ANTOINE <matthieu.antoine@jumo.world>
Co-authored-by: snolan-amount <55757441+snolan-amount@users.noreply.github.com>
ymylei pushed a commit to ymylei/terraform-provider-okta that referenced this pull request Sep 20, 2020
@mantoine96 @ymylei
Add external_namespace property for app_user_schema and user_schema (o…
bbdec98 
…kta#102)

LGTM!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@noinarisak noinarisak

Labels
bug enhancement Asking for new behavior or feature size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for external_namespace to okta_app_user_schema resource
2 participants
@mantoine96 @noinarisak