-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update app_oauth.html.markdown #151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update. Documentation on `"private_key_jwt:` in `resource_app_oauth` was missing.
ghost
added
the
size/XS
label
Jul 16, 2020
noinarisak
added a commit
to noinarisak/terraform-provider-okta
that referenced
this pull request
Jul 30, 2020
* Update app_oauth.html.markdown Update. Documentation on `"private_key_jwt:` in `resource_app_oauth` was missing. * Add example hcl for private_key_jwt Co-authored-by: noi narisak <noi.narisak@users.noreply.github.com>
ymylei
added a commit
to ymylei/terraform-provider-okta
that referenced
this pull request
Sep 20, 2020
* Add resource definiton for Okta Event Hooks (#14) * Add resource definiton for Okta Event Hooks This adds a new okta_event_hook resource for managing Event Hooks. The resource itself is mostly a copy/paste job from the existing okta_inline_hook resource. Since the two are so similar I re-worked sdk/inline_hooks.go to generalize it to work with both event hooks and inline hooks and renamed it to sdk/hooks.go. * Revert CHANGELOG.md The changelog entries get created by maintainers as part of the release process. * Get rid of overly-clever JSON formatting * Split hooks.go back apart into inline_hooks.go and event_hooks.go * Clean up and add comments to help explain testCheckResourceSetAttr * Adding support for GROUP_MEMBERSHIP_ADMIN & REPORT_ADMIN (okta#138) * adding documentation on the support of the group membership admin role * added group membership role to list of allowed options * updating tests to account for new group role * added REPORT_ADMIN to API validated roles and test * Removing comment on activating since this is now GA * Fixed provider_id typo in okta_factor in web documentation (okta#126) * Fixed provider_id typo in okta_factor Taken from https://github.com/articulate/terraform-provider-okta/blob/master/okta/resource_okta_factor.go * Added allowed provider_id values for factor resource web page Based on https://github.com/articulate/oktasdk-go/blob/master/okta/org.go * Fix terraform import command for okta_mfa_policy (okta#127) To import okta_mfa_policy the policy ID is required, an app id will not work. * Update app_oauth.html.markdown (okta#151) * Update app_oauth.html.markdown Update. Documentation on `"private_key_jwt:` in `resource_app_oauth` was missing. * Add example hcl for private_key_jwt Co-authored-by: noi narisak <noi.narisak@users.noreply.github.com> * Update CHANGELOG.md * Fix due the Hashicorp expecting particular CHANGLOG format * v3.4.0 * Cleanup after v3.4.0 release * Update .goreleaser.yml * Update CHANGELOG.md (okta#169) Co-authored-by: noi narisak <noi.narisak@users.noreply.github.com> * Add external_namespace property for app_user_schema and user_schema (okta#102) LGTM! * Add password import inline hook type (okta#168) Co-authored-by: noi narisak <noi.narisak@users.noreply.github.com> * Fix inline hook example code to match version that is supported (okta#175) Co-authored-by: noi narisak <noi.narisak@users.noreply.github.com> * Update app_group_assignment.html.markdown (okta#165) Corrected the help for importing, as per the help in the CLI, you need the app_id and group_id not the assignment id. * Update CHANGELOG (okta#177) Co-authored-by: noi narisak <noi.narisak@users.noreply.github.com> * Update .goreleaser.yml (okta#178) Co-authored-by: noi narisak <noi.narisak@users.noreply.github.com> Co-authored-by: Miles Budnek <mbudnek@mbudnek.com> Co-authored-by: Krzysztof Szyper <45788587+ChristophShyper@users.noreply.github.com> Co-authored-by: Kevin Behrens <kevin@thekbb.net> Co-authored-by: Noi Narisak <341437+noinarisak@users.noreply.github.com> Co-authored-by: noi narisak <noi.narisak@users.noreply.github.com> Co-authored-by: Tracy P Holmes <12778804+tracypholmes@users.noreply.github.com> Co-authored-by: tf-release-bot <terraform@hashicorp.com> Co-authored-by: Joel Franusic <joel@franusic.com> Co-authored-by: Matthieu ANTOINE <matthieu.antoine@jumo.world> Co-authored-by: snolan-amount <55757441+snolan-amount@users.noreply.github.com>
ymylei
pushed a commit
to ymylei/terraform-provider-okta
that referenced
this pull request
Sep 20, 2020
* Update app_oauth.html.markdown Update. Documentation on `"private_key_jwt:` in `resource_app_oauth` was missing. * Add example hcl for private_key_jwt Co-authored-by: noi narisak <noi.narisak@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation for
"private_key_jwt:
inresource_app_oauth
becuase it was missing.