Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Job #948

Merged
merged 4 commits into from
Feb 7, 2022
Merged

CI Job #948

merged 4 commits into from
Feb 7, 2022

Conversation

ymylei
Copy link
Contributor

@ymylei ymylei commented Feb 4, 2022

This adds a job for master / prs which would:

  • Check formatting
  • Check Go vetting (and staticcheck)
  • Check linting
  • Test build
  • Run non-acceptance (non-live tests)

Would like to see this expanded on, but some of this basic stuff should be useful to keep the repo in a good state.

@monde monde self-requested a review February 7, 2022 18:56
@monde
Copy link
Collaborator

monde commented Feb 7, 2022

@ymylei I like this PR, I will discuss it with @bogdanprodan-okta

monde
monde approved these changes Feb 7, 2022
View reviewed changes
Copy link
Collaborator

@monde monde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@monde monde merged commit beb9021 into okta:master Feb 7, 2022
@ymylei ymylei deleted the ci branch February 7, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monde monde monde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ymylei @monde