Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for using new OIE authenticators as factors in the MFA policies. Specifically:
is_oie
attribute for bothokta_policy_mfa
andokta_policy_mfa_default
. This attribute specifies how to build the payload for creating/updating MFA policies for tenants that support the newauthenticators
component. The reason this is not computed is because technically you can use the legacyfactors
even in an OIE tenant. If an OIE tenant attempts to use factors, these will succeed in the API initially (and returnfactors
); however, upon any changes in the UI for an OIE tenant, everything will then be converted toauthenticators
. Thus,is_oie
can change from a computed perspective; however, more importantly, it's needed for theCREATE/UPDATE
operations to ensure that an OIE tenant usesauthenticators
(since it could also use factors) by updating thesettings
payload accordingly.@bogdanprodan-okta I was pretty thorough in my testing in 2 tenants (OIE and classic) and made sure everything was backwards compatible. Since this is a larger scoped PR I'm sure there's some more work that needs to be done. Open to more feedback.
Fixes: #878
Fixes: #879
Fixes: #880