Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #882
Confirmed locally testing creation of new
OKTA_MANAGED
cert and getting the resource to create/manage it. The READ wasn't necessary as originally suspected it was since I guess we still won't import but handle it first time on create which works properly handling the other success caseCOMPLETED
.Backwards compatible with the addition of the
certificate_source_type
parameter by using existing default value ofMANUAL
and setting as optional. Ideally, it might make sense to change this to required on next version bump and remove theMANUAL
as default as it's really an explicit user choice (and this mirrors the Okta API). If that were a preference for next version, I could quickly update./cc @bogdanprodan-okta