Added new okta_app_signon_policy and okta_app_sign_on_policy_rule resources
#714
Conversation
bogdanprodan-okta
added
new-data-source
There was a problem hiding this comment.
@monde and @bogdanprodan-okta . I got some thoughts about this PR, please look at my feedback.
Particularly the impact that would be to the customer when it comes between App SignOn Policy when it comes between Identity Engine and Classic. I think there is needs to be more warning docs that you can't use this resource without being an OIE tenant.
| @@ -0,0 +1,143 @@ | |||
| resource "okta_app_saml" "test" { | |||
There was a problem hiding this comment.
Very minor, bacis is misspelled on the tf file. 😄
|
|
||
| # okta_app_signon_policy | ||
|
|
||
| ~> **IMPORTANT NOTE:** This feature is only available as a part of the Identity Engine. [Contact support](mailto:dev-inquiries@okta.com) for further information. |
There was a problem hiding this comment.
I might even label this as WARNING, this okta resource is completely Okta Identity Engine tenant and will not work to manage new or existing App SignOn Policy on Okta Classic.
|
|
||
| # okta_app_signon_policy_rule | ||
|
|
||
| ~> **IMPORTANT NOTE:** This feature is only available as a part of the Identity Engine. [Contact support](mailto:dev-inquiries@okta.com) for further information. |
There was a problem hiding this comment.
I might even label this as WARNING, this okta resource is completely Okta Identity Engine tenant and will not work to manage new or existing App SignOn Policy on Okta Classic.
|
@monde and @bogdanprodan-okta Oh, are missing some accepting testing for new resources? Missing |
I'll add tests in another PR. |
bogdanprodan-okta
changed the title
okta_app_signon_policy and okta_app_sign_on_policy_rule resources
bogdanprodan-okta
added
the
identity engine
Fix #456
Fix #56