Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed status change for auth server policy rule #386

Merged
merged 1 commit into from
Mar 24, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions okta/resource_okta_auth_server_policy_rule.go
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,33 @@ func resourceAuthServerPolicyRuleUpdate(ctx context.Context, d *schema.ResourceD
if err != nil {
return diag.Errorf("failed to update auth server policy rule: %v", err)
}
if d.HasChange("status") {
err := handleAuthServerPolicyRuleLifecycle(ctx, d, m)
if err != nil {
return err
}
}
return resourceAuthServerPolicyRuleRead(ctx, d, m)
}

func handleAuthServerPolicyRuleLifecycle(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
client := getSupplementFromMetadata(m)
if d.Get("status").(string) == statusActive {
_, err := client.ActivateAuthorizationServerPolicyRule(ctx, d.Get("auth_server_id").(string),
d.Get("policy_id").(string), d.Id())
if err != nil {
return diag.Errorf("failed to activate authorization server: %v", err)
}
return nil
}
_, err := client.DeactivateAuthorizationServerPolicyRule(ctx, d.Get("auth_server_id").(string),
d.Get("policy_id").(string), d.Id())
if err != nil {
return diag.Errorf("failed to deactivate authorization server: %v", err)
}
return nil
}

func resourceAuthServerPolicyRuleDelete(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
_, err := getSupplementFromMetadata(m).DeleteAuthorizationServerPolicyRule(
ctx,
Expand Down
21 changes: 21 additions & 0 deletions sdk/authorization_server_policy_rules.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,24 @@ func (m *ApiSupplement) GetAuthorizationServerPolicyRule(ctx context.Context, au
}
return &authorizationServer, resp, nil
}

func (m *ApiSupplement) ActivateAuthorizationServerPolicyRule(ctx context.Context, authServerID, policyID, ruleID string) (*okta.Response, error) {
return m.changeAuthorizationServerPolicyRuleLifecycle(ctx, authServerID, policyID, ruleID, "activate")
}

func (m *ApiSupplement) DeactivateAuthorizationServerPolicyRule(ctx context.Context, authServerID, policyID, ruleID string) (*okta.Response, error) {
return m.changeAuthorizationServerPolicyRuleLifecycle(ctx, authServerID, policyID, ruleID, "deactivate")
}

func (m *ApiSupplement) changeAuthorizationServerPolicyRuleLifecycle(ctx context.Context, authServerID, policyID, ruleID, action string) (*okta.Response, error) {
url := fmt.Sprintf("/api/v1/authorizationServers/%s/policies/%s/rules/%s/lifecycle/%s", authServerID, policyID, ruleID, action)
req, err := m.RequestExecutor.WithAccept("application/json").WithContentType("application/json").NewRequest("POST", url, nil)
if err != nil {
return nil, err
}
resp, err := m.RequestExecutor.Do(ctx, req, nil)
if err != nil {
return resp, err
}
return resp, nil
}