Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added case for idp_discovery since default name is different than other types #244

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

nickerzb
Copy link
Contributor

@nickerzb nickerzb commented Dec 16, 2020

[{"type":"IDP_DISCOVERY","id":"00p1d71a9Ckq59Snm5d6","status":"ACTIVE","name":"Idp Discovery Policy","description":"The default IdP Discovery Policy","priority":1,"system":true,"conditions":null,"created":"2020-11-25T18:53:28.000Z","lastUpdated":"2020-11-25T18:53:28.000Z","_links":{"self":{"href":"https://<tenant_redacted>/api/v1/policies/00p1d71a9Ckq59Snm5d6","hints":{"allow":["GET","PUT"]}},"rules":{"href":"https://<tenant_redacted>/api/v1/policies/00p1d71a9Ckq59Snm5d6/rules","hints":{"allow":["GET","POST"]}}}}]

This is a result of a curl for /api/v1/policies?type=IDP_DISCOVERY. The default policy name is not Default Policy like the other policy types. I would have expected a system policy to have a consistent name, but it seems IDP_DISCOVERY is different, so the existing code fails for that type.

Okta Terraform Version: 3.7.1
Terraform Version: 0.14.2
Resource: okta_default_policy

#232

@bogdanprodan-okta
Copy link
Contributor

Hi @nickerzb ! Thanks for the PR. This seems like an issue, so I'll merge your PR after all the checks go green.

@ngoble-phdata
Copy link
Contributor

Hi @nickerzb ! Thanks for the PR. This seems like an issue, so I'll merge your PR after all the checks go green.

Thank you! Hopefully this will finally let me use the default idp policy in my Terraform! :D

@bogdanprodan-okta bogdanprodan-okta merged commit 20e6c0d into okta:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants