Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add keys attribute to okta_app_saml resource #1206

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

ericnorris
Copy link
Contributor

This pull request adds a keys attribute to the okta_app_saml resource. We've put the methods used to pull the data into app.go, so it could potentially be added to other okta_app_* resources, and also their matching data sources.

Our use case is in setting up org2org with OAuth, where we'd like to create an okta_app_saml resource in one organization, and an okta_app_oauth service app in the other.

Without the keys attribute, we've resorted to manually calling the /credentials/keys endpoint and adding them as JWK blocks in okta_app_oauth. We'd prefer to have this process be as automated as possible, so adding the keys to the application resource made sense to us.

@monde monde self-requested a review July 19, 2022 17:30
@monde
Copy link
Collaborator

monde commented Jul 19, 2022

Thanks for the PR @ericnorris ! Apologies for the slow reply as I'm just getting back from vacation. I should be able to look at this by the end of this week.

@ericnorris
Copy link
Contributor Author

Hey @monde, apologies for the ping, but any chance you'd be able to take a look at this PR this week or next?

@monde
Copy link
Collaborator

monde commented Jul 29, 2022

got test confirmation from @ericnorris and @slichtenthal

=== RUN   TestAccAppSaml_conditionalRequire
--- PASS: TestAccAppSaml_conditionalRequire (5.35s)
PASS
ok  	github.com/okta/terraform-provider-okta/okta	5.647s
=== RUN   TestAccAppSaml_invalidURL
--- PASS: TestAccAppSaml_invalidURL (1.79s)
PASS
ok  	github.com/okta/terraform-provider-okta/okta	2.107s
=== RUN   TestAccAppSaml_crud
--- PASS: TestAccAppSaml_crud (55.85s)
PASS
ok  	github.com/okta/terraform-provider-okta/okta	56.183s
=== RUN   TestAccAppSaml_preconfigured
--- PASS: TestAccAppSaml_preconfigured (47.41s)
PASS
ok  	github.com/okta/terraform-provider-okta/okta	48.140s
=== RUN   TestAccAppSaml_userGroups
--- PASS: TestAccAppSaml_userGroups (33.04s)
PASS
ok  	github.com/okta/terraform-provider-okta/okta	33.404s
=== RUN   TestAccAppSaml_inlineHook
--- PASS: TestAccAppSaml_inlineHook (45.70s)
PASS
ok  	github.com/okta/terraform-provider-okta/okta	46.090s
=== RUN   TestAccAppSaml_federationBroker
    resource_okta_app_saml_test.go:302: This is an 'Early Access Feature' and needs to be enabled by Okta, skipping this test as it fails when this feature is not available
--- SKIP: TestAccAppSaml_federationBroker (0.00s)
PASS
ok  	github.com/okta/terraform-provider-okta/okta	0.407s

Copy link
Collaborator

@monde monde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go @ericnorris and @slichtenthal

@monde monde merged commit 2e77e3d into okta:master Jul 29, 2022
@monde monde mentioned this pull request Jul 29, 2022
@monde
Copy link
Collaborator

monde commented Jul 29, 2022

Released in https://github.com/okta/terraform-provider-okta/releases/tag/v3.32.0

@ericnorris ericnorris deleted the feat-add-app-saml-keys-attr branch August 4, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants