Fixed error handler (#366)

* Fixed error handler * Removed validation for 'single_logout_issuer'
okta · Mar 5, 2021 · a285e87 · a285e87
1 parent e4751a5
commit a285e87
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/okta/config.go b/okta/config.go
@@ -97,10 +97,10 @@ func (c *Config) loadAndValidate() error {
 }
 
 func errHandler(resp *http.Response, err error, numTries int) (*http.Response, error) {
-	defer resp.Body.Close()
 	if err != nil {
-		return nil, err
+		return resp, err
 	}
+	defer resp.Body.Close()
 	err = okta.CheckResponseForError(resp)
 	if err != nil {
 		oErr, ok := err.(*okta.Error)

diff --git a/okta/resource_okta_app_saml.go b/okta/resource_okta_app_saml.go
@@ -325,11 +325,10 @@ func resourceAppSaml() *schema.Resource {
 				},
 			},
 			"single_logout_issuer": {
-				Type:             schema.TypeString,
-				Optional:         true,
-				Description:      "The issuer of the Service Provider that generates the Single Logout request",
-				ValidateDiagFunc: stringIsURL(validURLSchemes...),
-				RequiredWith:     []string{"single_logout_url", "single_logout_certificate"},
+				Type:         schema.TypeString,
+				Optional:     true,
+				Description:  "The issuer of the Service Provider that generates the Single Logout request",
+				RequiredWith: []string{"single_logout_url", "single_logout_certificate"},
 			},
 			"single_logout_url": {
 				Type:             schema.TypeString,