Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#740] Fix order dependency of setter methods when setAuthorizationMode(PRIVATE_KEY) is used #741

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

er1c
Copy link
Contributor

@er1c er1c commented Jun 28, 2022

I have already signed the CLA.

Issue(s)

#740

Description

Un-necessary guards were added to prevent setting certain fields if the setAuthorizationMode hadn't been previously set. There are additional guards in place as part of the build() method.

Category

  • Bugfix
  • Enhancement
  • New Feature
  • Library Upgrade
  • Configuration Change
  • Versioning Change
  • Unit or Integration Test(s)
  • Documentation

Signoff

  • I have submitted a CLA for this PR
  • Each commit message explains what the commit does
  • I have updated documentation to explain what my PR does
  • My code is covered by tests if required
  • I did not edit any automatically generated files

@JayNewstrom
Copy link

Thanks for the PR @er1c I'll let Arvind review.

@er1c
Copy link
Contributor Author

er1c commented Jun 28, 2022

@arvindkrishnakumar-okta feel free to steal/create a new PR/whatever if you still want the guards in place in the actual setter methods.

@er1c er1c force-pushed the 740-client-builder-order branch from 74e6f32 to 9b5646f Compare June 28, 2022 20:46
@er1c
Copy link
Contributor Author

er1c commented Jun 28, 2022

I just put the setter method asserts back in, and fixed miss-naming of the assertion message input parameter names.

@er1c
Copy link
Contributor Author

er1c commented Jun 29, 2022

@arvindkrishnakumar-okta friendly ping :)

@arvindkrishnakumar-okta
Copy link
Contributor

@arvindkrishnakumar-okta friendly ping :)

Reviewed it and looks good to me. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants