Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate userAgent string #139

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Remove duplicate userAgent string #139

merged 1 commit into from
Dec 11, 2017

Conversation

bdemers
Copy link
Contributor

@bdemers bdemers commented Dec 11, 2017

Fixes: #135

Copy link
Collaborator

@bretterer bretterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for including a test!

@codecov-io
Copy link

codecov-io commented Dec 11, 2017

Codecov Report

Merging #139 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #139      +/-   ##
============================================
- Coverage     60.84%   60.84%   -0.01%     
  Complexity     1312     1312              
============================================
  Files           155      155              
  Lines          5272     5271       -1     
  Branches        836      836              
============================================
- Hits           3208     3207       -1     
  Misses         1719     1719              
  Partials        345      345
Impacted Files Coverage Δ Complexity Δ
...java/com/okta/sdk/impl/http/support/UserAgent.java 34.78% <100%> (-0.41%) 22 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29ccb6e...f98fd95. Read the comment docs.

@bdemers bdemers merged commit f328de6 into master Dec 11, 2017
@bdemers bdemers deleted the issue-135 branch December 11, 2017 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants