Service stop should not be called

[denysoblohin-okta]

Changes:

• Removes oktaAuth.stop() from <Security>
• Removes oktaAuth.start() from <LoginCallback> after handleLoginRedirect - not needed
• Fixed useEffect hook in <Security> - don't watch for restoreOriginalUri prop to perform side-effects (start, subscribe, unsubscribe) on oktaAuth
• Updated okta-auth-js to latest

Internal ref: OKTA-492710 (including deps OKTA-482712 OKTA-482710)

[jaredperreault-okta]

What is the purpose of this Promise.resolve?

[denysoblohin-okta]

To wait for handleLoginRedirect which is a promise

[jaredperreault-okta]

You can put the await in the expect call

expect(await oktaAuth.handleLoginRedirect)

or

await expect(oktaAuth.handleLoginRedirect).resolves.toHaveBeenCalled()

[denysoblohin-okta]

handleLoginRedirect should be called inside useEffect of <LoginCallback />
Previous implementation included excess start() after promise resolves:

oktaAuth.handleLoginRedirect().then(() => {
      oktaAuth.start() // not needed
    })

In this test we need to wait for handleLoginRedirect to be called implicitly inside useEffect and resolved, then check start() was not called.

Awaiting it explicitly in test would not work

[denysoblohin-okta]

    await act(async () => {
      mount(
        <Security {...mockProps}>
          <LoginCallback />
        </Security>
      );
    });

this works without need of await Promise.resolve();