🌱 Make responseType configurable

packages/okta-angular/README.md

@@ -37,6 +37,7 @@ The `OktaAuthModule` is the initializer for your OpenID Connect client configura
   - `clientId` **(required)**: The OpenID Connect `client_id`
   - `redirectUri` **(required)**: Where the callback is hosted
   - `scope` *(optional)*: Reserved for custom claims to be returned in the tokens
+  - `responseType` *(optional)*: Desired token grant types
   - `onAuthRequired` *(optional)*: Accepts a callback to make a decision when authentication is required. If not supplied, `okta-angular` will redirect directly to Okta for authentication.
 
 ```typescript
@@ -48,8 +49,8 @@ import {
 
 const oktaConfig = {
   issuer: 'https://{yourOktaDomain}.com/oauth2/default',
-  redirectUri: 'http://localhost:{port}/implicit/callback',
-  clientId: '{clientId}'
+  clientId: '{clientId}',
+  redirectUri: 'http://localhost:{port}/implicit/callback'
 }
 
 const appRoutes: Routes = [

packages/okta-angular/package.json

@@ -12,7 +12,9 @@
     "prestart": "npm run build:dependencies",
     "prepublish": "npm run ngc",
     "ngc": "./node_modules/.bin/ngc -p tsconfig.json",
-    "test": "npm run --prefix test/e2e/harness/ e2e",
+    "test": "npm run lint && npm run test:unit && npm run test:e2e",
+    "test:unit": "npm run --prefix test/e2e/harness/ test",
+    "test:e2e": "npm run --prefix test/e2e/harness/ e2e",
     "start": "npm run --prefix test/e2e/harness/ start",
     "docs": "typedoc --options typedoc.json --exclude '{**/*.spec.ts,**/test/**}' ./src/",
     "lint": "npm run --prefix test/e2e/harness/ lint",

packages/okta-angular/src/okta/okta.config.ts

@@ -18,6 +18,7 @@ export interface OktaConfig {
   clientId?: string;
   scope?: string;
   onAuthRequired?: Function;
+  responseType?: string;
 }
 
 export const OKTA_CONFIG = new InjectionToken<OktaConfig>('okta.config.angular');

packages/okta-angular/src/okta/okta.service.ts

@@ -102,7 +102,7 @@ export class OktaAuthService {
      */
     loginRedirect(additionalParams?: object) {
       this.oktaAuth.token.getWithRedirect({
-        responseType: ['id_token', 'token'],
+        responseType: (this.config.responseType || 'id_token token').split(' '),
         // Convert scopes to list of strings
         scopes: this.config.scope.split(' '),
         ...additionalParams

packages/okta-angular/test/e2e/harness/package.json

@@ -7,7 +7,7 @@
     "start": "npm run env && ng serve --port=3000",
     "env": "node ./scripts/prebuild.js",
     "build": "ng build",
-    "test": "ng test",
+    "test": "ng test -watch=false",
     "lint": "ng lint",
     "e2e": "npm run env && ng e2e -port 3000"
   },

packages/okta-angular/test/e2e/harness/src/app/app.component.spec.ts

@@ -0,0 +1,55 @@
+import { TestBed, async, ComponentFixture } from '@angular/core/testing';
+import { RouterTestingModule } from '@angular/router/testing';
+import { AppComponent } from './app.component';
+import { environment } from './../environments/environment';
+
+import {
+  OktaAuthGuard,
+  OktaAuthModule,
+  OktaCallbackComponent,
+  OktaLoginRedirectComponent
+} from '@okta/okta-angular';
+
+describe('Unit Tests', () => {
+  let component: AppComponent;
+  let fixture: ComponentFixture<AppComponent>;
+
+  beforeEach(() => {
+    const config = {
+      issuer: environment.ISSUER,
+      redirectUri: environment.REDIRECT_URI,
+      clientId: environment.CLIENT_ID,
+      scope: 'email',
+      responseType: 'id_token'
+    };
+
+    TestBed.configureTestingModule({
+      imports: [
+        RouterTestingModule.withRoutes([{ path: 'foo', redirectTo: '/foo' }]),
+        OktaAuthModule.initAuth(config)
+      ],
+      declarations: [
+        AppComponent
+      ]
+    });
+  });
+
+  beforeEach(() => {
+    fixture = TestBed.createComponent(AppComponent);
+    component = fixture.componentInstance;
+    fixture.detectChanges();
+  });
+
+  it('should create the app', async(() => {
+    expect(component).toBeTruthy();
+  }));
+
+  it('should instantiate the OktaAuth object', async(() => {
+    const config = component.oktaAuth.getOktaConfig();
+    expect(config.issuer).toBe(environment.ISSUER);
+    expect(config.redirectUri).toBe(environment.REDIRECT_URI);
+    expect(config.clientId).toBe(environment.CLIENT_ID);
+    expect(config.scope).toBe('email openid');
+    expect(config.responseType).toBe('id_token');
+  }));
+});

packages/okta-angular/test/e2e/harness/src/app/app.module.ts

@@ -31,15 +31,15 @@ import {
  */
 import { ProtectedComponent } from './protected.component';
 import { AppComponent } from './app.component';
-import { SessionTokenLogin } from './sessionToken-login.component';
+import { SessionTokenLoginComponent } from './sessionToken-login.component';
 
 export function onNeedsAuthenticationGuard({ oktaAuth, router }) {
   router.navigate(['/sessionToken-login']);
-};
+}
 
 export function onNeedsGlobalAuthenticationGuard({ oktaAuth, router }) {
   router.navigate(['/login']);
-};
+}
 
 const appRoutes: Routes = [
   {
@@ -48,7 +48,7 @@ const appRoutes: Routes = [
   },
   {
     path: 'sessionToken-login',
-    component: SessionTokenLogin
+    component: SessionTokenLoginComponent
   },
   {
     path: 'implicit/callback',
@@ -74,6 +74,7 @@ const config = {
   redirectUri: environment.REDIRECT_URI,
   clientId: environment.CLIENT_ID,
   scope: 'email',
+  responseType: 'id_token token',
   onAuthRequired: onNeedsGlobalAuthenticationGuard
 };
 
@@ -86,7 +87,7 @@ const config = {
   declarations: [
     AppComponent,
     ProtectedComponent,
-    SessionTokenLogin
+    SessionTokenLoginComponent
   ],
   bootstrap: [ AppComponent ]
 })

packages/okta-angular/test/e2e/harness/src/app/sessionToken-login.component.ts

@@ -16,10 +16,10 @@ import { OktaAuthService } from '@okta/okta-angular';
 import OktaAuth from '@okta/okta-auth-js';
 
 @Component({
-  selector: 'app-sessionLogin',
+  selector: 'app-session-login',
   template: `
   <router-outlet></router-outlet>
-  
+
   <div>
   <br/>
     <label>
@@ -32,7 +32,7 @@ import OktaAuth from '@okta/okta-auth-js';
   </div>
   `
 })
-export class SessionTokenLogin {
+export class SessionTokenLoginComponent {
   oktaAuth: OktaAuth;
 
   constructor(private okta: OktaAuthService) {