Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support email verify callback #990

Closed
wants to merge 27 commits into from

Conversation

aarongranick-okta
Copy link
Contributor

@aarongranick-okta aarongranick-okta commented Oct 28, 2021

  • passes stateTokenExternalId to introspect
  • allows shared storage without "oauth" flag (meant for legacy oauth cookies)
  • clears shared storage if a matching state exists in sessionStorage
  • do not bundle node-cache for browser version
  • add _idxResponse to auth-js methods (to help widget conversion)
  • separate shared storage for originalUri
  • upgrades idx-js and fixes tests (no longer throws a "raw" idx response)
  • shared storage is automatically enabled only in browser environment
  • isInteractionRequired now supported on node platform
  • updates express-embedded-auth-with-sdk sample:
    • handles email verify callback (on /login/callback)
    • displays more error types (instead of "Internal Error!")

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 92.45283% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.28%. Comparing base (2a753a0) to head (787f7af).
Report is 353 commits behind head on master.

Files with missing lines Patch % Lines
lib/OktaAuth.ts 78.12% 7 Missing ⚠️
lib/idx/remediate.ts 90.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #990   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         121      122    +1     
  Lines        3512     3566   +54     
  Branches      736      759   +23     
=======================================
+ Hits         3241     3291   +50     
- Misses        271      275    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aarongranick-okta aarongranick-okta marked this pull request as ready for review October 28, 2021 18:26
lib/util/emailVerify.ts Outdated Show resolved Hide resolved
@aarongranick-okta aarongranick-okta force-pushed the ag-OKTA-429210-external-state-token branch 2 times, most recently from 2a9e18e to 4999727 Compare November 3, 2021 15:43
@aarongranick-okta aarongranick-okta force-pushed the ag-OKTA-429210-external-state-token branch from ee7f3ea to 787f7af Compare November 4, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants