Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: interface SignInWithRedirectOptions should extend TokenParams #986

Closed
wants to merge 2 commits into from
Closed

Fix: interface SignInWithRedirectOptions should extend TokenParams #986

wants to merge 2 commits into from

Conversation

denysoblohin-okta
Copy link
Contributor

Copy of #960
Interface SignInWithRedirectOptions should extend TokenParams
Internal ref: OKTA-432799

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2021 •
edited
Loading

Codecov Report

Merging #986 (5f008a1) into master (05d880a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #986   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files         121      121           
  Lines        3510     3510           
  Branches      735      735           
=======================================
  Hits         3240     3240           
  Misses        270      270

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05d880a...5f008a1. Read the comment docs.

@kYem
Copy link

kYem commented Oct 28, 2021

Can this finally be merged?
An issue that wasted a lot of my time, trying to understand why idp parameter was not accepted, that turn out to be the interface issue

@denysoblohin-okta denysoblohin-okta force-pushed the od-add-TokenParams-to-SignInWithRedirectOptions-OKTA-432799 branch from 003e52a to 5f008a1 Compare October 28, 2021 22:05
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Oct 28, 2021
@eng-prod-CI-bot-okta
Fix: interface SignInWithRedirectOptions should extend TokenParams
535a1e1 
OKTA-432799
<<<Jenkins Check-In of Tested SHA: 5f008a1 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-auth-js
Files changed count: 2
PR Link: "#986"
@shuowu shuowu mentioned this pull request Feb 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuowu shuowu shuowu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@denysoblohin-okta @codecov-commenter @kYem @shuowu @eng-prod-CI-bot-2-okta