Updates IDX API options parameter type to optional
#981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuowu
approved these changes
Oct 21, 2021
There was a problem hiding this comment.
Thanks @shawyu-okta for the PR, do you mind also add a simple description for this change in the changelog.md?
It can be some thing like
5.7.0
### Features
Allows optional paramters for idx methods
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Oct 21, 2021
OKTA-439728 <<<Jenkins Check-In of Tested SHA: ef8554e for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 3 PR Link: "#981"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IDX API documentation shows on-demand usage of the API to allow
optionsparameter to be optional. Currently, the types for some of the APIs indicate they should be required. This PR changes the type to be optional for those IDX APIs.