fix issues with refresh token #832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #832 +/- ##
==========================================
- Coverage 91.70% 91.45% -0.25%
==========================================
Files 114 116 +2
Lines 3268 3313 +45
Branches 679 688 +9
==========================================
+ Hits 2997 3030 +33
- Misses 271 283 +12
Continue to review full report at Codecov.
|
shuowu
reviewed
Jun 24, 2021
lib/TokenManager.ts
Outdated
| @@ -359,19 +353,15 @@ export class TokenManager { | |||
| this.emitRemoved(key, removedToken); | |||
| } | |||
|
|
|||
| // TODO: these methods are redundant and can be removed in the next major version | |||
There was a problem hiding this comment.
let's add a jira to track it.
shuowu
reviewed
Jun 24, 2021
| return this.sdk.token.renew(token); | ||
| } | ||
| validateToken(token: Token) { |
There was a problem hiding this comment.
also remove this one in 6.0?
- do not try to renew the refresh token - catch refresh token failure and remove token - prevent invalid refresh tokens from being stored
aarongranick-okta
force-pushed
the
ag-OKTA-403154-refresh-token
branch
from
f94f167 to
802a128
Compare
shuowu-okta
reviewed
Jun 24, 2021
|
|
||
| - [#832](https://github.com/okta/okta-auth-js/pull/832) Fixes issues with refresh tokens | ||
|
|
||
| ## 5.1.1 |
There was a problem hiding this comment.
Thanks for adding all those changelogs, I'll just close my PR #835
shuowu
reviewed
Jun 25, 2021
| @@ -45,7 +45,7 @@ Feature: Multi-Factor Authentication with Password and SMS | |||
| When She selects SMS from the list | |||
| And She inputs a invalid phone number | |||
| And She selects "Receive a Code" | |||
| Then she should see a message "Unable to initiate factor enrollment: Invalid Phone Number." | |||
There was a problem hiding this comment.
probably search the error message in the code base, looks like still missing one e2e test case and some unit tests (probably not necessary).
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Jun 25, 2021
- do not try to renew the refresh token - catch refresh token failure and remove token - prevent invalid refresh tokens from being stored fix: support rotating refresh tokens Update string for phone enroll error OKTA-329744 update error msg OKTA-403154 <<<Jenkins Check-In of Tested SHA: 5673490 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 31 PR Link: "#832"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#738
#747
#784
OKTA-399459
OKTA-400565
OKTA-397735
OKTA-403154