fix: promise returned on fetch missing finally #616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In Edge 17 and lower the promise returned by fetch api call doesnt have finally on it. * Fix is if finally is not present on promise returned by fetch we explicitly wrap it with a promise. RESOLVES: OKTA-367504
test/spec/fetch-request.js
Outdated
| }); | ||
| it('fetchRequest returns a promise with finally on it even if fetch doesnt return a promise with fetch', () => { | ||
| const globalFetch = jest.fn(() => { | ||
| const resolvedPromise = Promise.resolve(response); |
There was a problem hiding this comment.
In this case can we return a bare object? or
{
then: jest.fn(),
catch: jest.fn()
}
I want to be sure finally cannot be called through the prototype, it should never exist.
aarongranick-okta
approved these changes
Feb 3, 2021
haishengwu-okta
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Edge 17 and lower the promise returned by fetch api call doesnt have
finally on it.
Fix is if finally is not present on promise returned by fetch we explicitly wrap it with
a promise.
RESOLVES: OKTA-367504
Chrome
chrome.mov
Edge
edge17.mov