Add idps option for config for Signin widget flow #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandrpravosudko-okta
approved these changes
Dec 23, 2020
denysoblohin-okta
force-pushed
the
add-idps-for-widget
branch
from
f421e0e to
fb192e8
Compare
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
==========================================
+ Coverage 92.96% 93.70% +0.73%
==========================================
Files 38 42 +4
Lines 2161 3017 +856
Branches 452 711 +259
==========================================
+ Hits 2009 2827 +818
- Misses 152 190 +38
Continue to review full report at Codecov.
|
oleksandrpravosudko-okta
approved these changes
Jan 15, 2021
swiftone
reviewed
Feb 1, 2021
Comment on lines
216
to
224
| idps: config.idps.split(/\s+/).map(v => { | ||
| const parts = v.split(/:/); | ||
| if (parts.length == 2) { | ||
| return {type: parts[0], id: parts[1]}; | ||
| } | ||
| return null; | ||
| }).filter(v => v) | ||
| }); |
There was a problem hiding this comment.
nit: (very nit). I like to keep the visual focus on the relevant parts of code to make it easier for the next coder who is skimming over the code and may not be familiar with it. What do you think of this:
config.idps.split(/\s+/).map(idpToken => {
const [type, id] = idpToken.split(/:/);
if(!type || !id) {
return null;
}
return { type, id};
}).filter(v => v);
b46a430 to
a4abac3
Compare
denysoblohin-okta
force-pushed
the
add-idps-for-widget
branch
from
a4abac3 to
af85bde
Compare
aarongranick-okta
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
idpsto for sample config UI for Signin Widget flow.