Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mfa types - OKTA-343852 #554

Closed
wants to merge 2 commits into from
Closed

Conversation

shuowu
Copy link
Contributor

@shuowu shuowu commented Dec 3, 2020

This change adds one level depth types for class AuthTransaction.

@shuowu-okta shuowu-okta force-pushed the sw-add-mfa-types-OKTA-343852 branch from b635b65 to b24bb01 Compare December 4, 2020 15:41
@shuowu-okta shuowu-okta force-pushed the sw-add-mfa-types-OKTA-343852 branch from 956c7d4 to d13665f Compare December 4, 2020 19:57
@codecov-io
Copy link

codecov-io commented Dec 4, 2020

Codecov Report

Merging #554 (d13665f) into master (d82e99b) will decrease coverage by 1.13%.
The diff coverage is 84.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
- Coverage   92.60%   91.47%   -1.14%     
==========================================
  Files          37       37              
  Lines        2070     2123      +53     
  Branches      420      439      +19     
==========================================
+ Hits         1917     1942      +25     
- Misses        153      181      +28     
Impacted Files Coverage Δ
lib/tx/TransactionState.ts 100.00% <ø> (ø)
lib/browser/browser.ts 90.62% <31.25%> (-4.57%) ⬇️
lib/TokenManager.ts 96.68% <75.00%> (-1.27%) ⬇️
lib/token.ts 93.43% <88.65%> (-2.95%) ⬇️
lib/AuthStateManager.ts 91.75% <100.00%> (ø)
lib/constants.ts 100.00% <100.00%> (ø)
lib/tx/AuthTransaction.ts 91.34% <100.00%> (ø)
lib/types/Token.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3afa1fe...d13665f. Read the comment docs.

@shuowu-okta shuowu-okta force-pushed the sw-add-mfa-types-OKTA-343852 branch from d13665f to 3ad5275 Compare December 4, 2020 20:20
@shuowu
Copy link
Contributor Author

shuowu commented Dec 4, 2020

Screen Shot 2020-12-04 at 3 34 33 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants