🐛 Checks for IE11 localStorage #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lboyette-okta
force-pushed
the
lb-105205-localStorage-check
branch
from
48ef84c to
2777a9a
Compare
Resolves: OKTA-105205
lboyette-okta
force-pushed
the
lb-105205-localStorage-check
branch
from
2777a9a to
0ff509f
Compare
rchild-okta
reviewed
Dec 20, 2016
| sessionStorage.clear(); | ||
| return oauthUtil.getWellKnown(test.oa) | ||
| .then(function() { | ||
| return oauthUtil.getWellKnown(test.oa); |
There was a problem hiding this comment.
Why are we making the getWellKnown call twice?
There was a problem hiding this comment.
It's not necessary. I didn't remove it after a copy/paste from another test. Will remove
| 'test-idToken': tokens.standardIdTokenParsed | ||
| }); | ||
| }); | ||
| it('defaults to cookieStorage if localStorage nor sessionStorage is available', function() { |
There was a problem hiding this comment.
nit: "neither localStorage..." or "localStorage and sessionStorage are not..."
magizh-okta
pushed a commit
to magizh-okta/okta-auth-js
that referenced
this pull request
Sep 23, 2019
Small updates to the README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localStorage and sessionStorage aren't available in some scenarios on IE11. This commit handles those scenarios by first attempting to fallback to sessionStorage, then cookies if sessionStorage doesn't exist.
Tested with widget in IE11 after starting using these instructions:
Resolves: OKTA-105205