Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change distributed filename to okta-auth-js #50

Merged
merged 1 commit into from
Oct 24, 2016

Conversation

lboyette-okta
Copy link
Contributor

@lboyette-okta lboyette-okta commented Oct 21, 2016

Resolves: OKTA-104120

@rchild-okta @magizh-okta

This changes future distributed assets from:

https://ok1static.oktacdn.com/assets/js/sdk/okta-auth-js/x.x.x/OktaAuth.min.js

to:

https://ok1static.oktacdn.com/assets/js/sdk/okta-auth-js/x.x.x/okta-auth-js.min.js

in order to match okta-signin-widget:

https://ok1static.oktacdn.com/assets/js/sdk/okta-signin-widget/x.x.x/js/okta-sign-in.min.js

edit: just noticed our okta-signin-widget name is pretty strange itself. Should we change "okta-sign-in.min.js" to "okta-signin-widget.min.js"?

Copy link
Contributor

@magizh-okta magizh-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lboyette-okta
Copy link
Contributor Author

lboyette-okta commented Oct 21, 2016

@magizh-okta Because this only affects future assets, the docs don't need to be changed yet.

Copy link
Contributor

@rchild-okta rchild-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@lboyette-okta lboyette-okta force-pushed the lb-104120-rename-asset branch from 5bcf0ab to 11637ec Compare October 24, 2016 19:32
@lboyette-okta lboyette-okta merged commit 7310870 into master Oct 24, 2016
@jmelberg-okta jmelberg-okta deleted the lb-104120-rename-asset branch April 23, 2018 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants