Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove headers with undefined value #468

Merged
merged 3 commits into from
Sep 28, 2020

Conversation

aarongranick-okta
Copy link
Contributor

In 4.0 we switched from util.extend to Object.assign. The side-effect is that "undefined" headers which were being removed are now being passed with the value "undefined".

  • Adds unit tests for HTTP requestor

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2020

Codecov Report

Merging #468 into master will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #468      +/-   ##
==========================================
+ Coverage   90.13%   90.47%   +0.33%     
==========================================
  Files          31       31              
  Lines        1561     1574      +13     
  Branches      342      344       +2     
==========================================
+ Hits         1407     1424      +17     
+ Misses        154      150       -4     
Impacted Files Coverage Δ
lib/OktaAuthBase.ts 82.35% <ø> (ø)
lib/browser/browser.ts 93.06% <ø> (ø)
lib/TokenManager.ts 97.02% <100.00%> (+0.22%) ⬆️
lib/http.ts 100.00% <100.00%> (+3.38%) ⬆️
lib/server/serverStorage.ts 100.00% <0.00%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a721765...087fb5c. Read the comment docs.

@aarongranick-okta
Copy link
Contributor Author

@shuowu @swiftone This should have gone in with 4.0.1 but it was forgotten. Maybe we can get this in for 4.0.2. The regression was observed in the SIW, which has not switched to auth-js 4.0 yet.

@aarongranick-okta aarongranick-okta merged commit 517337f into master Sep 28, 2020
@aarongranick-okta aarongranick-okta deleted the ag-OKTA-325445-fix-nil-headers branch September 28, 2020 17:03
aarongranick-okta added a commit that referenced this pull request Oct 26, 2020
* fix: remove headers with undefined value
aarongranick-okta added a commit that referenced this pull request Oct 29, 2020
* fix: remove headers with undefined value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants