Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added token.getUserInfo #41

Merged
merged 2 commits into from
Sep 20, 2016
Merged

Added token.getUserInfo #41

merged 2 commits into from
Sep 20, 2016

Conversation

lboyette-okta
Copy link
Contributor

@lboyette-okta lboyette-okta commented Sep 19, 2016

@@ -5,14 +5,18 @@ var Q = require('q');
var AuthApiError = require('./errors/AuthApiError');
var config = require('./config');

function httpRequest(sdk, url, method, args, dontSaveResponse) {
function httpRequest(sdk, url, method, args, dontSaveResponse, accessToken) {
Copy link
Contributor

@haishengwu-okta haishengwu-okta Sep 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: taking an parameter (type Object) seems slightly better? (it probably needs to refactor many places)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I considered this, but wanted to change as little as possible. It'd also remove the need for changing the eslint rules

Copy link
Contributor

@haishengwu-okta haishengwu-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rchild-okta rchild-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me - it might be nice to add in another test for "what happens if the response is an error, i.e. invalid access token"

🚀

Copy link
Contributor

@rchild-okta rchild-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm 🚀

@lboyette-okta lboyette-okta merged commit a4147b3 into master Sep 20, 2016
@jmelberg-okta jmelberg-okta deleted the lb-100558-UserInfo branch April 23, 2018 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants