-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added token.getUserInfo #41
Conversation
Resolves: OKTA-100558
@@ -5,14 +5,18 @@ var Q = require('q'); | |||
var AuthApiError = require('./errors/AuthApiError'); | |||
var config = require('./config'); | |||
|
|||
function httpRequest(sdk, url, method, args, dontSaveResponse) { | |||
function httpRequest(sdk, url, method, args, dontSaveResponse, accessToken) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: taking an parameter (type Object
) seems slightly better? (it probably needs to refactor many places)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I considered this, but wanted to change as little as possible. It'd also remove the need for changing the eslint rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me - it might be nice to add in another test for "what happens if the response is an error, i.e. invalid access token"
🚀
82941d3
to
4b31c80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm 🚀
Resolves: OKTA-100558
@rchild-okta
@haishengwu-okta
http://developer.okta.com/docs/api/resources/oidc.html#get-user-information