getToken takes only a single set of options #320
Conversation
aarongranick-okta
force-pushed
the
ag-gettoken-options-OKTA-106994
branch
from
efb562a to
3b5d7ba
Compare
CHANGELOG.md
Outdated
| @@ -22,6 +22,8 @@ | |||
|
|
|||
| - [#317](https://github.com/okta/okta-auth-js/pull/317) - `pkce` option is now `true` by default. `grantType` option is removed. | |||
|
|
|||
| - [#320](https://github.com/okta/okta-auth-js/pull/320) - `getWithRedirect`, `getWithPopup`, and `getWithoutPrompt` take a single options object | |||
There was a problem hiding this comment.
Wouldn't a more informative note say what has been dropped? If I'm passing two options today, and the CHANGELOG tells me I should only send one, I don't know which one.
| function getWithoutPrompt(sdk, oauthOptions, options) { | ||
| var oauthParams = util.clone(oauthOptions) || {}; | ||
| util.extend(oauthParams, { | ||
| function getWithoutPrompt(sdk, options) { |
There was a problem hiding this comment.
The README uses "oauthOptions", which does have the advantage of being more specific. Is there a reason to make it more generic? (If so, we should update the README to match, but hopefully we can go with the descriptive, um, option)
There was a problem hiding this comment.
The reason there were 2 sets of options is because the first set was supposed to correspond to the OAUTH 2.0 spec, whereas the 2nd set included our "internal" options. Over time, the set of options we support has drifted from this original intention. Now that they are merged, there is no distinction. All options are part of OUR spec and may not necessarily map directly to the OAUTH 2.0 spec. So I think the README should be updated
aarongranick-okta
force-pushed
the
v3.0
branch
2 times, most recently
from
937963b to
7ccdf7c
Compare
aarongranick-okta
force-pushed
the
ag-gettoken-options-OKTA-106994
branch
from
edcb2e4 to
aa70faa
Compare
aarongranick-okta
force-pushed
the
v3.0
branch
2 times, most recently
from
bb8730d to
8a29ce5
Compare
aarongranick-okta
force-pushed
the
ag-gettoken-options-OKTA-106994
branch
from
aa70faa to
1d8082c
Compare
No description provided.