-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: E2E test flows + new app harness #256
Conversation
8dca763
to
4e1c1d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
but curious how we made decision to use wdio.js instead of testcafe which has been used in many products today.
Why the testcafe is not used? |
@haishengwu-okta @pradeepdewda-okta I was not aware there was a decision/direction to use testcafe. I'm sure the tests could be rewritten to use testcafe, I'm curious what would be the advantage? |
We are using TestCafe for the sign-in-widget, my-okta, Azuqua and for Courage e2e. I strongly recommend using it over Selenium because of its several automatic anti-flakiness features. The biggest advantage I see personally is that you don't have to write any more 'waitFor' code before interacting with elements like this: If you have any questions, feel free to reach out. |
@richardheng-okta FYI: I have started working on converting the tests to testcafe. I think I have hit a blocker, which is support for popup windows. Apparently testcafe can only run in a single window so all popups and links are opened in the same window. This will not allow us to properly test our login flow which uses a popup and message communication between the windows. DevExpress/testcafe#912 @robertjd I think it may be best to merge this PR, with webdriver IO tests. We can add an item on backlog to convert to testcafe when/if support for multiple windows is added. (Although the issue is 3 years old, it appears they ARE working on it) |
@aarongranick-okta That seems reasonable to me. Thanks for looking into it! |
E2E tests with coverage on:
Adds an improved test harness app