Removed dependency on global window object. #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dale-cooper Thank you for catching this! This code is being hit when you have the |
|
@dale-cooper Your fix was merged, we will release a new version of the library soon! Thank you for contributing! |
|
@dale-cooper Version with the fix released: https://github.com/okta/okta-auth-js/releases/tag/okta-auth-js-2.3.1 :) |
|
amazing - thanks for this fix guys 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
as of the documentation I should be able to use okta-auth-js from nodejs (at least in part). In practice this leads to an exception very fast because 'window' is not defined in node.
Best
Christian