replaces jsonpath-plus module #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawyu-okta
reviewed
Oct 16, 2024
shawyu-okta
reviewed
Oct 16, 2024
| resolved "https://registry.yarnpkg.com/ansi-regex/-/ansi-regex-4.1.1.tgz#164daac87ab2d6f6db3a29875e2d1766582dabed" | ||
| integrity sha512-ILlv4k/3f6vfQ4OoP2AGvirOktlQ98ZEL1k9FaQjxa3L1abBgbuTDAdPOpvbGncC0BTVQrl+OM8xZGK6tWXt7g== | ||
|
|
||
| ansi-regex@^3.0.1, ansi-regex@^6.0.1: |
There was a problem hiding this comment.
I was expecting to see jsonpath-plus removed in this diff but it isn't
There was a problem hiding this comment.
jared:auth-js$ yarn why jsonpath-plus
yarn why v1.22.19
[1/4] 🤔 Why do we have the module "jsonpath-plus"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "jsonpath-plus@6.0.1"
info Reasons this module exists
- "_project_#@okta#samples.express-embedded-sign-in-widget#@okta#okta-signin-widget#@okta#okta-auth-js" depends on it
- Hoisted from "_project_#@okta#samples.express-embedded-sign-in-widget#@okta#okta-signin-widget#@okta#okta-auth-js#jsonpath-plus"
- Hoisted from "_project_#@okta#samples.react-embedded-auth-with-sdk#@okta#okta-signin-widget#@okta#okta-auth-js#jsonpath-plus"
- Hoisted from "_project_#@okta#samples.webpack-spa#@okta#okta-signin-widget#@okta#okta-auth-js#jsonpath-plus"
info Disk size without dependencies: "372KB"
info Disk size with unique dependencies: "372KB"
info Disk size with transitive dependencies: "372KB"
info Number of shared dependencies: 0
✨ Done in 0.56s.There was a problem hiding this comment.
We include samples in the repo
Closed
shawyu-okta
reviewed
Oct 16, 2024
lib/util/jsonpath.ts
Outdated
Comment on lines
7
to
12
| while ((match = jsonpathRegex.exec(path)) !== null) { | ||
| const step = match?.groups?.step ?? match?.groups?.index; | ||
| if (step) { | ||
| steps.push(step); | ||
| } | ||
| } |
There was a problem hiding this comment.
Formatting is kind of wonky, it's not failing lint?
shawyu-okta
approved these changes
Oct 16, 2024
shawyu-okta
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsonpath-plusin vulnerable to RCE: https://security.snyk.io/vuln/SNYK-JS-JSONPATHPLUS-7945884