Handle fetch exceptions #1487
Merged
Handle fetch exceptions #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuowu-okta
reviewed
Jan 23, 2024
lib/http/request.ts
Outdated
| if (error instanceof Error) { | ||
| // fetch() can throw exceptions | ||
| // see https://developer.mozilla.org/en-US/docs/Web/API/fetch#exceptions | ||
| return new OAuthError('fetch_error', error.message); |
There was a problem hiding this comment.
how about use AuthApiError here?
shuowu-okta
approved these changes
Jan 23, 2024
denysoblohin-okta
force-pushed
the
od-fetch-error-OKTA-668419
branch
from
c26f1f6 to
2c2b9a4
Compare
eng-services-aperture-github-bot-okta
deleted the
od-fetch-error-OKTA-668419
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetchcan throw exceptions: https://developer.mozilla.org/en-US/docs/Web/API/fetch#exceptionsformatError currently will return
AuthApiErrorwithxhrproperty set toTypeErrorobject.generateIdxAction will try to parse
xhras JSON and will trigger errorSyntaxError: "undefined" is not valid JSONYou can reproduce with SIW playground with mock authenticator-enroll-select-authenticator-with-skip having incorrect url
http://localhost:3000:1802/idp/idx/cancel. Clicking onBack to sign inwill trigger errorSyntaxError: "undefined" is not valid JSONinstead ofOAuthError: Failed to execute 'fetch' on 'Window': Failed to parse URL from http://localhost:3000:1802/idp/idx/cancelIssue for SIW: OKTA-668419