Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge 1481 #1482

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Merge 1481 #1482

merged 3 commits into from
Jan 18, 2024

Conversation

jaredperreault-okta
Copy link
Contributor

No description provided.

@jaredperreault-okta jaredperreault-okta changed the title Merge 1480 Merge 1481 Jan 12, 2024
@jaredperreault-okta jaredperreault-okta changed the base branch from master to 7.5 January 17, 2024 19:50
nholik and others added 3 commits January 18, 2024 12:18
@nholik @jaredperreault-okta
fix: Allows aud to be an array when validating claims
8ed908d 
Per the openid spec, aud can be an array and in special cases a single
string.  This fixes a bug where the array case is not handled.  This is
a non breaking change.

Resolves: Issue [#1480](#1480)
@nholik @jaredperreault-okta
test: Adds unit tests for aud claim validation
8b8a097 
Tests for the following scenarios:
- aud is an array but does NOT contain the clientId throws an error
- aud is an array and does contain the clientId validates with no error

Resolves: [1480](#1480)
@jaredperreault-okta
clean up
ec495f9
@nholik
Copy link
Contributor

nholik commented Jan 19, 2024

So you took my work then squash + merge to erase any evidence of my contribution. Not really a good way to encourage the community to help out.

jaredperreault-okta added a commit that referenced this pull request Jan 20, 2024
@jaredperreault-okta
Revert "Merge 1481 (#1482)"
b4ab67b 
This reverts commit 82b5602.
@jaredperreault-okta
Copy link
Contributor Author

jaredperreault-okta commented Jan 20, 2024 •
edited
Loading

All of our merges are done in CI and our CI only runs branches created by Okta employees (I'm not sure why). Our CI automatically does a rebase before merging. I'll work on fixing the git history

eng-services-aperture-github-bot-okta pushed a commit that referenced this pull request Jan 22, 2024
@jaredperreault-okta
Revert "Merge 1481 (#1482)" (#1489)
a5587ce 
OKTA-678622 Revert "Merge 1481 (#1482)"

This reverts commit 82b5602.
@jaredperreault-okta
Copy link
Contributor Author

History was fixed. Released in 7.5.1
https://github.com/okta/okta-auth-js/releases/tag/okta-auth-js-7.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesterchoi-okta lesterchoi-okta lesterchoi-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaredperreault-okta @nholik @lesterchoi-okta @eng-services-aperture-github-bot-okta