fix: Don't auto remediate SelectAuthenticator with current authenticator #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denysoblohin-okta
force-pushed
the
od-fix-auto-remediation-current-authenticator-OKTA-612939
branch
from
9b19963 to
c5af40c
Compare
denysoblohin-okta
force-pushed
the
od-fix-auto-remediation-current-authenticator-OKTA-612939
branch
6 times, most recently
from
f61a67a to
875791e
Compare
denysoblohin-okta
force-pushed
the
od-fix-auto-remediation-current-authenticator-OKTA-612939
branch
from
7dcadb2 to
0b2f16f
Compare
denysoblohin-okta
force-pushed
the
od-fix-auto-remediation-current-authenticator-OKTA-612939
branch
from
6813bec to
5f3a51f
Compare
jaredperreault-okta
approved these changes
Jul 18, 2023
denysoblohin-okta
force-pushed
the
od-fix-auto-remediation-current-authenticator-OKTA-612939
branch
from
baf5d13 to
5f3a51f
Compare
eng-services-aperture-github-bot-okta
deleted the
od-fix-auto-remediation-current-authenticator-OKTA-612939
branch
This was referenced Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Don't auto remediate
select-authenticator-authenticate/select-authenticator-enrollif authenticator has been already selected (currentAuthenticatorEnrollment/currentAuthenticatoris present in IDX response)Note:
currentAuthenticatoris used during enrollment,currentAuthenticatorEnrollmentduring verify flow. Both means the same, naming is confusing.Internal ref: OKTA-612939, OKTA-609234