Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cjs dynamic import transpiling issue - OKTA-488924 #1180

Closed
wants to merge 3 commits into from
Closed

fix: cjs dynamic import transpiling issue - OKTA-488924 #1180

wants to merge 3 commits into from

Conversation

shuowu
Copy link
Contributor

@shuowu shuowu commented Apr 14, 2022 •
edited
Loading

Fixes babel commonjs config, now it transpiles dynamic import to deferred require for cjs bundle.

return await _promise.default.resolve().then(() => _interopRequireWildcard(require('crypto')));

Resolves: #1176

eng-prod-CI-bot-okta pushed a commit that referenced this pull request Apr 14, 2022
@shuowu @eng-prod-CI-bot-okta
fix: cjs dynamic import transpiling issue - OKTA-488924
12b889c 
OKTA-488924
<<<Jenkins Check-In of Tested SHA: 8b2980f for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-auth-js
Files changed count: 3
PR Link: "#1180"
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Apr 14, 2022
@shuowu @eng-prod-CI-bot-okta
update changelog
627a744 
OKTA-488924
<<<Jenkins Check-In of Tested SHA: 8b2980f for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-auth-js
Files changed count: 3
PR Link: "#1180"
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Apr 14, 2022
@shuowu @eng-prod-CI-bot-okta
bump version to 6.4.2
df5296f 
OKTA-488924
<<<Jenkins Check-In of Tested SHA: 8b2980f for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-auth-js
Files changed count: 3
PR Link: "#1180"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredperreault-okta jaredperreault-okta jaredperreault-okta approved these changes

@aarongranick-okta aarongranick-okta aarongranick-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shuowu @aarongranick-okta @jaredperreault-okta @eng-services-aperture-github-bot-okta