Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete options.ts #1169

Closed
wants to merge 2 commits into from
Closed

Delete options.ts #1169

wants to merge 2 commits into from

Conversation

aarongranick-okta
Copy link
Contributor

@aarongranick-okta aarongranick-okta commented Apr 5, 2022 •
edited
Loading

File was deleted and inadvertently added back in a merge

@codecov-commenter
Copy link

Codecov Report

Merging #1169 (b8806f4) into 6.3 (9c47e44) will increase coverage by 0.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              6.3    #1169      +/-   ##
==========================================
+ Coverage   92.49%   93.02%   +0.52%     
==========================================
  Files         159      159              
  Lines        4477     4429      -48     
  Branches      992      981      -11     
==========================================
- Hits         4141     4120      -21     
+ Misses        316      289      -27     
  Partials       20       20
Impacted Files Coverage Δ
lib/server/serverStorage.ts
lib/options/index.ts 100.00% <0.00%> (ø)
lib/options/browser.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c47e44...b8806f4. Read the comment docs.

@shuowu
Copy link
Contributor

shuowu commented Apr 7, 2022

Resolves okta/okta-vue#95

@aarongranick-okta aarongranick-okta marked this pull request as ready for review April 8, 2022 15:00
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Apr 8, 2022
@aarongranick-okta @eng-prod-CI-bot-okta
Delete options.ts
d8949fd 
bump version 6.3.2, changelog

OKTA-424466
<<<Jenkins Check-In of Tested SHA: 97c218a for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-auth-js
Files changed count: 3
PR Link: "#1169"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuowu shuowu shuowu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aarongranick-okta @codecov-commenter @shuowu @eng-prod-CI-bot-okta