Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate browser and node modules at build time - OKTA-446542 #1109

Conversation

shuowu
Copy link
Contributor

@shuowu shuowu commented Feb 11, 2022

This change excludes node-cache package from browser related bundles (esm, umd, cdn) by separating environment specific logic at build time.

Downstream Tests (green):

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2022

Codecov Report

Merging #1109 (16cdcbf) into master (69baa22) will increase coverage by 0.66%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1109      +/-   ##
==========================================
+ Coverage   92.84%   93.51%   +0.66%     
==========================================
  Files         154      154              
  Lines        4209     4147      -62     
  Branches      921      906      -15     
==========================================
- Hits         3908     3878      -30     
+ Misses        285      253      -32     
  Partials       16       16              
Impacted Files Coverage Δ
lib/options/browser.ts 100.00% <100.00%> (ø)
lib/options/index.ts 100.00% <100.00%> (ø)
lib/crypto/node.ts
lib/server/serverStorage.ts
lib/crypto/browser.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69baa22...16cdcbf. Read the comment docs.

@shuowu shuowu marked this pull request as ready for review February 14, 2022 18:50
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Feb 14, 2022
OKTA-446542
<<<Jenkins Check-In of Tested SHA: 16cdcbf for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-auth-js
Files changed count: 8
PR Link: "#1109"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants