Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: browser field point to UMD bundle #1048

Closed
wants to merge 1 commit into from

Conversation

aarongranick-okta
Copy link
Contributor

incorrect value in the field was causing fallback to CJS, leading to inclusion of node code. OKTA-458043

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #1048 (34d4527) into master (65a0ba0) will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1048      +/-   ##
==========================================
+ Coverage   92.83%   93.05%   +0.22%     
==========================================
  Files         138      138              
  Lines        3770     4005     +235     
  Branches      784      865      +81     
==========================================
+ Hits         3500     3727     +227     
- Misses        270      278       +8     
Impacted Files Coverage Δ
lib/idx/cancel.ts 57.14% <0.00%> (-9.53%) ⬇️
...b/idx/remediators/AuthenticatorVerificationData.ts 96.00% <0.00%> (-4.00%) ⬇️
lib/idx/remediators/Base/Remediator.ts 90.20% <0.00%> (-2.10%) ⬇️
lib/idx/remediators/Skip.ts 100.00% <0.00%> (ø)
lib/idx/flow/FlowSpecification.ts 100.00% <0.00%> (ø)
lib/idx/remediators/AuthenticatorEnrollmentData.ts 100.00% <0.00%> (ø)
...idx/remediators/SelectAuthenticatorAuthenticate.ts 100.00% <0.00%> (ø)
lib/idx/remediators/Base/SelectAuthenticator.ts 98.21% <0.00%> (+0.48%) ⬆️
lib/idx/run.ts 99.21% <0.00%> (+1.68%) ⬆️
lib/idx/remediate.ts 95.90% <0.00%> (+2.04%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65a0ba0...34d4527. Read the comment docs.

eng-prod-CI-bot-okta pushed a commit that referenced this pull request Jan 6, 2022
OKTA-458043
<<<Jenkins Check-In of Tested SHA: 34d4527 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-auth-js
Files changed count: 1
PR Link: "#1048"
shuowu added a commit that referenced this pull request Jan 7, 2022
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Jan 7, 2022
OKTA-458631
<<<Jenkins Check-In of Tested SHA: ba58fe6 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-auth-js
Files changed count: 1
PR Link: "#1052"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants