refactor: idx methods now use auth-js http client

OKTA-417473
<<<Jenkins Check-In of Tested SHA: 4baca3d for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-auth-js
Files changed count: 76
PR Link: "#1145"

CHANGELOG.md

@@ -1,5 +1,21 @@
 # Changelog
 
+## 6.4
+
+### Fixes
+
+- [#1145](https://github.com/okta/okta-auth-js/pull/1145)
+  - IDX: form field-level messages are now passed through via idxState
+  - Type Fixes:
+    - IdxContent: `user` property now optional
+    - Input: added missing `key` property
+
+### Other
+
+- [#1145](https://github.com/okta/okta-auth-js/pull/1145)
+  - refactor: IDX methods now use auth-js http client
+  - refactor: idx-js methods have been refactored to idxState
+
 ## 6.3.0
 
 ### Features

lib/OktaAuth.ts

@@ -124,7 +124,6 @@ import {
   parseEmailVerifyCallback,
   isEmailVerifyCallbackError
 } from './idx';
-import { createGlobalRequestInterceptor, setGlobalRequestInterceptor } from './idx/headers';
 import { OktaUserAgent } from './OktaUserAgent';
 import { parseOAuthResponseFromUrl } from './oidc/parseFromUrl';
 import {
@@ -336,8 +335,6 @@ class OktaAuth implements OktaAuthInterface, SigninAPI, SignoutAPI {
       unlockAccount: unlockAccount.bind(null, this),
     };
 
-    setGlobalRequestInterceptor(createGlobalRequestInterceptor(this)); // to pass custom headers to IDX endpoints
-
     // HTTP
     this.http = {
       setRequestHeader: setRequestHeader.bind(null, this)

lib/fetch/fetchRequest.ts

@@ -13,6 +13,9 @@
 import crossFetch from 'cross-fetch';
 import { FetchOptions, HttpResponse } from '../types';
 
+// content-type = application/json OR application/ion+json
+const appJsonContentTypeRegex = /application\/\w*\+?json/;
+
 function readData(response: Response): Promise<object | string> {
   if (response.headers.get('Content-Type') &&
     // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
@@ -54,10 +57,18 @@ function fetchRequest(method: string, url: string, args: FetchOptions) {
   var headers = args.headers || {};
   var contentType = (headers['Content-Type'] || headers['content-type'] || '');
 
-  // JSON encode body (if appropriate)
-  if (contentType === 'application/json' && body && typeof body !== 'string') {
-    body = JSON.stringify(body);
+  if (body && typeof body !== 'string') {
+    // JSON encode body (if appropriate)
+    if (appJsonContentTypeRegex.test(contentType)) {
+      body = JSON.stringify(body);
+    }
+    else if (contentType === 'application/x-www-form-urlencoded') {
+      body = Object.entries(body)
+      .map( ([param, value]) => `${param}=${encodeURIComponent(value)}` )
+      .join('&');
+    }
   }
+
   var fetch = global.fetch || crossFetch;
   var fetchPromise = fetch(url, {
     method: method,