Skip to content

Commit

Permalink
refactor(core): optimize image loading
Browse files Browse the repository at this point in the history
- JavaScript runs so fast that LQIP will never be detected
- Increase the running priority of image processing in posts

Enhancement for mmistakes#1267
  • Loading branch information
cotes2020 committed Sep 28, 2023
1 parent b489da8 commit e3b0163
Show file tree
Hide file tree
Showing 4 changed files with 56 additions and 24 deletions.
4 changes: 3 additions & 1 deletion _includes/refactor-content.html
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
{% assign _left = _left | remove: ' /' | replace: ' w=', ' width=' | replace: ' h=', ' height=' %}
{% assign _attrs = _left | split: '" ' %}

{% assign _src = null %}
{% assign _lqip = null %}
{% assign _class = null %}

Expand Down Expand Up @@ -119,8 +120,9 @@
{% endunless %}

{% if _lqip %}
{% if _lqip contains ':' %}
{% if _lqip contains 'data:' %}
{% assign _lazyload = false %}
{% assign _class = _class | append: ' blur' %}
{% else %}
{% assign _lqip_alt = 'lqip="' | append: _path_prefix %}
{% assign _left = _left | replace: 'lqip="', _lqip_alt %}
Expand Down
70 changes: 50 additions & 20 deletions _javascript/modules/components/img-loading.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,30 +2,60 @@
* Setting up image lazy loading and LQIP switching
*/

export function loadImg() {
const $images = $('main img[loading="lazy"]');
const $lqip = $('main img[data-lqip="true"]');
const ATTR_DATA_SRC = 'data-src';
const ATTR_DATA_LQIP = 'data-lqip';
const C_SHIMMER = 'shimmer';
const C_BLUR = 'blur';

if ($images.length > 0) {
$images.on('load', function () {
/* Stop shimmer when image loaded */
$(this).parent().removeClass('shimmer');
});
function handleImage() {
const $img = $(this);

$images.each(function () {
/* Images loaded from the browser cache do not trigger the 'load' event */
if ($(this).prop('complete')) {
$(this).parent().removeClass('shimmer');
}
});
if (this.hasAttribute(ATTR_DATA_LQIP) && this.complete) {
$img.parent().removeClass(C_BLUR);
} else {
$img.parent().removeClass(C_SHIMMER);
}
}

/* Switch LQIP with real image url */
function switchLQIP(img) {
// Sometimes loaded from cache without 'data-src'
if (img.hasAttribute(ATTR_DATA_SRC)) {
const $img = $(img);
const dataSrc = $img.attr(ATTR_DATA_SRC);
$img.attr('src', encodeURI(dataSrc));
}
}

export function loadImg() {
const $images = $('article img');

if ($images.length) {
$images.on('load', handleImage);
}

if ($lqip.length > 0) {
$lqip.each(function () {
/* Switch LQIP with real image url */
const dataSrc = $(this).attr('data-src');
$(this).attr('src', encodeURI(dataSrc));
$(this).removeAttr('data-src data-lqip');
/* Images loaded from the browser cache do not trigger the 'load' event */
$('article img[loading="lazy"]').each(function () {
if (this.complete) {
$(this).parent().removeClass(C_SHIMMER);
}
});

const $lqips = $(`article img[${ATTR_DATA_LQIP}="true"]`);

if ($lqips.length) {
const isHome = $('#post-list').length > 0;

$lqips.each(function () {
if (isHome) {
// JavaScript runs so fast that LQIPs in home page will never be detected
// Delay 50ms to ensure LQIPs visibility
setTimeout(() => {
switchLQIP(this);
}, 50);
} else {
switchLQIP(this);
}
});
}
}
2 changes: 1 addition & 1 deletion _javascript/post.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ import {
toc
} from './modules/plugins';

basic();
initSidebar();
initTopbar();
loadImg();
imgPopup();
initLocaleDatetime();
initClipboard();
toc();
basic();
4 changes: 2 additions & 2 deletions _sass/addon/commons.scss
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ a {
img {
max-width: 100%;
height: auto;
transition: all 0.7s ease-in-out;
transition: all 0.35s ease-in-out;

&[data-lqip='true'] {
.blur & {
$blur: 20px;

-webkit-filter: blur($blur);
Expand Down

0 comments on commit e3b0163

Please sign in to comment.