Skip to content

Commit

Permalink
278 - MacOS Notarize (#621)
Browse files Browse the repository at this point in the history
* 278 - Add MacOS notarize files and secrets

* Fix typo

* Allow notarize in PRs

* Add notarize secrets to the action

* Upgrade electron-builder

* Add some extra resources to the file

* Clean debugging option
  • Loading branch information
pdelboca authored Nov 1, 2024
1 parent c28a359 commit 1c73fd8
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/general.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,11 @@ jobs:
run: make dist
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CSC_LINK: ${{ secrets.CSC_LINK }}
CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
- name: Archive build artifacts
uses: actions/upload-artifact@v4
with:
Expand Down
10 changes: 8 additions & 2 deletions electron-builder.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,15 @@ linux:
- deb

# Macos

# Some resources to understand values and github secrets
# https://kilianvalkhof.com/2019/electron/notarizing-your-electron-application/
# https://www.electron.build/code-signing
# https://www.electron.build/app-builder-lib.interface.macconfiguration#notarize
# https://github.com/electron/notarize
mac:
notarize: false
hardenedRuntime: true
entitlements: 'entitlements.mac.plist'
entitlementsInherit: 'entitlements.mac.plist'

# Windows
# Variable ${name} doesn't work on windows
Expand Down
10 changes: 10 additions & 0 deletions entitlements.mac.plist
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>com.apple.security.cs.allow-unsigned-executable-memory</key>
<true/>
<key>com.apple.security.cs.allow-jit</key>
<true/>
</dict>
</plist>
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"delay": "6.0.0",
"dirty-json": "0.9.2",
"electron": "31.3.0",
"electron-builder": "^24.13.3",
"electron-builder": "^25.0.5",
"electron-updater": "6.2.1",
"electron-vite": "2.1.0",
"eslint": "8.45.0",
Expand Down

0 comments on commit 1c73fd8

Please sign in to comment.